-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor remaining resources and data sources #522
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcmjunior
changed the title
Refactor remaining
Refactor remaining resources and data sources
Apr 6, 2024
cyral_integration_*
resources and data sources
VictorGFM
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Just have a minor comment below
Co-authored-by: Victor Moraes <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Refactor the following resources and data sources:
cyral_integration_mfa_duo
cyral_integration_pager_duty
cyral_integration_idp_saml
cyral_integration_idp_saml_draft
cyral_integration_logging
cyral_permission
cyral_policy
cyral_policy_rule
cyral_rego_policy_instance
cyral_service_account
cyral_sidecar_health
cyral_sidecar_instance
cyral_sidecar_instance_stats
cyral_system_info
Type of change
Checklists
Development
Code review
Testing
Besides running acceptance tests (see results below), I also ran the following manual tests for each changed resource:
terraform apply
;terraform apply
again. The provider successfully suggested the creation of a new resource and did not error out.terraform destroy
. The provider successfully remove the resource from the state completing the destroy command without erroring out.Acceptance test results: